Support solution path which is simply a filename. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes launching like so: Giles -s MySolution.sln -t (...)
|
Hey Mario! Can you see if this works with the latest bits? |
|
I'll try and check this out later tonight. |
|
I've merged all your recent changes from master into this branch and verified it still works as expected. Here are the steps to reproduce the original bug: Unhandled Exception: System.ArgumentException: The directory name is invalid. |
Conflicts: src/Giles.Specs/Core/Watchers/SourceWatcherSpecs.cs
|
Damn, looks like recent changes have broken the ability to auto merge this, sorry!! :( |
|
I'll try to update branch later tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes launching like so: Giles -s MySolution.sln -t (...)